Allow this to work under gevent by using grequests#6
Open
richtera wants to merge 7 commits intogns24:masterfrom
Open
Allow this to work under gevent by using grequests#6richtera wants to merge 7 commits intogns24:masterfrom
richtera wants to merge 7 commits intogns24:masterfrom
Conversation
Contributor
Author
|
Sorry this patch is not quite right. |
added 2 commits
March 24, 2014 12:09
Contributor
Author
|
This now works although I figured out the hang was due to the fact that uwsgi's main thread (the one loading the wsgi file) is suspended and cannot be used to make requests, httplib2 or urllib3 calls. At least this is what cleared out my hangs. |
Contributor
There was a problem hiding this comment.
Instead of doing this, you probably want to abstract out the transport layer from the database, and pass the transport in Database.init().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check whether gevent is loader and if it is, then use grequests instead of requests.
Otherwise this module hangs a system with gevent loaded.