Test Array in mat_rclist_*#1213
Closed
alexvong243f wants to merge 3 commits into
Closed
Conversation
added 3 commits
August 29, 2022 08:10
Fixes gnu-octave#1211. * inst/private/python_header.py: Add it. * inst/private/python_ipc_native.m: Add it.
See gnu-octave#1194 for more information. * inst/@sym/private/mat_rclist_access.m: Test it.
See gnu-octave#1194 for more information. * inst/@sym/private/mat_rclist_asgn.m: Test it.
Collaborator
|
This looks good at a quick glance. Should we merge it to #1194 instead of main? |
Collaborator
Author
|
Sure, I can merge this to https://github.com/cbm755/octsympy/tree/Array_not_Matrix instead of This should be safer than merging to |
alexvong243f
pushed a commit
to alexvong243f/octsympy
that referenced
this pull request
Aug 30, 2022
alexvong243f
pushed a commit
to alexvong243f/octsympy
that referenced
this pull request
Aug 30, 2022
Collaborator
Author
|
Merged onto https://github.com/cbm755/octsympy/tree/Array_not_Matrix in 5385713 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the mat_rclist_* functions
Array-compatible.We also add the
make_matrix_or_arrayhelper function as well, which fixes #1211.dbg_no_arrayis set toTruefor now to avoid failing tests inmain.