feat: add Floor/Ceil and TimeRange for time-based ID queries#5
Open
klaidliadon wants to merge 9 commits intomasterfrom
Open
feat: add Floor/Ceil and TimeRange for time-based ID queries#5klaidliadon wants to merge 9 commits intomasterfrom
klaidliadon wants to merge 9 commits intomasterfrom
Conversation
Add FloorUUID, CeilUUID, FloorInt64, CeilInt64 for constructing boundary IDs from timestamps. Add generic TimeRange[T] with ToSql for squirrel-compatible range queries against PK indexes.
Move Floor/Ceil functions and TimeRange type into timerange/ sub-package. Add UUID and Int64 interfaces for prefix-erased type assertions.
Boundary IDs don't carry a prefix — return UUID/Int64 interfaces from unexported concrete types instead of requiring a type parameter. Drops the typeid import from the timerange package.
TimeRange is now a plain struct storing driver.Valuer bounds. No generics left in the timerange package.
Replace two interfaces + two unexported concrete types with a single generic ID[T int64 | uuid.UUID] struct. Type aliases UUID and Int64 preserve the familiar names.
Add GetTime/Floor/Ceil directly to UUID[P] and Int64[P]. Delete the timerange sub-package and ID[T] generic type — no new types needed since Floor/Ceil construct the existing types directly via val access.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FloorUUID,CeilUUID,FloorInt64,CeilInt64— construct min/max boundary IDs for a given timestampTimeRange[T]type withToSql()(structurally satisfiessquirrel.Sqlizer) for range queries against PK indexesUUIDRangeandInt64Rangeconstructors that accept*time.Timefor optional since/until boundsTest Plan
go test ./...passes