Apply new function wg.Go in Go 1.25#131
Closed
Eric-Guo wants to merge 5 commits intogo-dev-frame:mainfrom
Closed
Conversation
Eric-Guo
force-pushed
the
new_wg_Go
branch
4 times, most recently
from
0aa0548 to
f16e8ff
Compare
…new function wg.Go in sponge?
…en deprecated since Go 1.24 and an alternative has been available since Go 1.2: OFB mode is not authenticated, which generally enables active attacks to manipulate and recover the plaintext. It is recommended that applications use [AEAD] modes instead. The standard library implementation of OFB is also unoptimized and not validated as part of the FIPS 140-3 module. If an unauthenticated [Stream] mode is required, use [NewCTR] instead. (staticcheck)
…all to (*testing.common).Logf
…compile because sync.WaitGroup does not provide a Go method—only Add/Done/Wait. In addition, the paired wg.Done() call in worker() was removed, so even if this did build, every Wait() would block forever because the counter never reaches zero. Please revert to wg.Add(1) plus go ...; defer wg.Done() or switch to the intended primitive (e.g., errgroup) across these sites.
Contributor
Author
|
Cloase as codex is not yet learning the Go 1.25, so review process will break. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Re the article: Go 1.25 adds WaitGroup.Go to automatically manage Add/Done for goroutines, simplifying concurrency and avoiding common counter misuse.
Prompt for GPT-5-high
Can you read https://mfbmina.dev/en/posts/waitgroups/ and apply the new function wg.Go in sponge ?