Fix: remove hard dependency on gorm.io/driver/mysql#328
Open
dannyota wants to merge 1 commit into
Open
Conversation
Replace direct *mysql.Dialector type assertions with a reflection-based isMariaDB() helper to read the ServerVersion field. This removes the compile-time dependency on gorm.io/driver/mysql from production code, so library consumers no longer transitively pull in the MySQL driver. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What did this pull request do?
Replace
*mysql.Dialectortype assertions with reflection-basedisMariaDB()helper to readServerVersion. Removesgorm.io/driver/mysqlimport fromjson.go,json_map.go,json_type.go.Fixes #160
User Case Description
Consumers of
gorm.io/datatypestransitively pull ingorm.io/driver/mysqleven if they only use PostgreSQL or SQLite. After this change, all driver dependencies are test-only.Replaces #321. The original PR could not be reopened after its source fork was deleted.