fix: replace hardcoded JWT and session keys with env var lookups in auth examples#53
Open
saaa99999999 wants to merge 1 commit into
Open
Conversation
- auth/jwt/main.go: replaced hardcoded "testKey" and "serviceTestKey" with
getEnvOrDefault() reading from JWT_TEST_KEY / JWT_SERVICE_TEST_KEY env vars
- http/session/main.go: replaced hardcoded []byte("secret") session key with
getEnvOrDefault() reading from SESSION_SECRET_KEY env var
This is the official JWT auth example for the Kratos framework. Developers
who copy this code get a JWT system using a known default signing key.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The official Kratos JWT auth example and session example use hardcoded signing keys in the source code itself.
What was there
auth/jwt/main.go — the JWT authentication example hardcodes two keys:
This is the top result when searching "kratos jwt example". The key "testKey" signs and verifies all tokens.
http/session/main.go — Redis session encryption key:
What changed
Added getEnvOrDefault() helper, replaced hardcoded strings:
See also: CWE-798