Allow configuring scopes and extraUserInfo#98
Draft
joscha-alisch wants to merge 1 commit intogo-pkgz:masterfrom
Draft
Allow configuring scopes and extraUserInfo#98joscha-alisch wants to merge 1 commit intogo-pkgz:masterfrom
joscha-alisch wants to merge 1 commit intogo-pkgz:masterfrom
Conversation
Pull Request Test Coverage Report for Build 1311457085
💛 - Coveralls |
Member
|
it would be nice to cover the change with tests. almost 5% coverage decrease by itself is not such a problem, however not having any tests for extra functionality - is a problem. |
Author
|
Certainly :) this was not intended as a ready-to-merge PR, but rather as a first iteration to get feedback on the direction. Hence the draft PR. I'll go ahead and add tests. |
Member
|
@joscha-alisch I'm not sure if you expect me to review the PR as it is marked as draft |
Author
|
No, i Just didn't have time to add the tests yet. Will let you know when it's ready :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new method to add providers that allows to configure additional scopes and a hook that is called with the authenticated HTTP client. This is a draft to resolve issue #97 .
Usage is like this for the GitHub provider for example, which would fetch the orgs/teams a user is in and attach them to the user.Token.