Deduplicate C logical operators from int domains#1963
Draft
sim642 wants to merge 1 commit intoint-predicatesfrom
Draft
Deduplicate C logical operators from int domains#1963sim642 wants to merge 1 commit intoint-predicatesfrom
sim642 wants to merge 1 commit intoint-predicatesfrom
Conversation
sim642
added
cleanup
Extracted to base instead.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is on top of #1962.
I was first going to also change these to return
bool optionin #1962 but then I realized how silly all of this is.Each one of the int domains implements these in a slightly different way but they all boil down to going through
to_boolandof_bool.So we had six implementations of the same thing, with some being slightly worse than others by not doing annihilation.
This can also be defined one and for all in base where the expressions are actually evaluated. And these int domain operations aren't used for anything else, nor can they do anything more precise in a particular domain.
Extracted to base instead.