Replace list-then-empty-check patterns with short-circuiting alternatives#224
Open
Replace list-then-empty-check patterns with short-circuiting alternatives#224
Conversation
…ives Co-authored-by: michael-schwarz <13812333+michael-schwarz@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Audit for list short-circuiting opportunities
Replace list-then-empty-check patterns with short-circuiting alternatives
Mar 19, 2026
michael-schwarz
requested changes
Mar 19, 2026
Member
|
Should be considered in addition to #222. |
Co-authored-by: michael-schwarz <13812333+michael-schwarz@users.noreply.github.com>
michael-schwarz
approved these changes
Mar 19, 2026
Co-authored-by: michael-schwarz <13812333+michael-schwarz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several places computed a full filtered list only to check whether it was empty (or use just its first element), wasting work on the remaining elements.
Changes
src/check.ml(×2) — label lookup inAddrOfLabel/Goto: replacedList.filter (function Label _ -> …) … :: _withList.find_opt, which stops at the firstLabelmatch.src/frontc/cabs2cil.ml—unrollDesignatorForNestedAnonymous: replacedList.filter (fun fld -> fld.fname = designator)+fld :: _match withList.exists, since the found value is not needed — only whether a matching field exists.<issue_title>Audit for list short-circuiting opportunities</issue_title>
Original prompt
📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.