INC-5131: APIController: /api/apply pretend PRs have been approved#87
Merged
Conversation
When a request to apply run is given from the /api/, we don't have enough context regarding if the PR has actually been approved or not. To work around this, we fake it, and pretend the PR is okay. -- Note, this is _not_ the same code path that is used when the `atlantis apply` comment is posted on a Github PR. This only applies to runs that are triggered, bypassing the normal GH comment process. This code can be disabled by unsetting ATLANTIS_API_SECRET to disable these APIs.
ttamimi
approved these changes
Apr 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a request to apply run is given from the /api/, we don't have enough context regarding if the PR has actually been approved or not.
To work around this, we fake it, and pretend the PR is okay. --
Note, this is not the same code path that is used when the
atlantis applycomment is posted on a Github PR.This only applies to runs that are triggered, bypassing the normal GH comment process. This code can be disabled by unsetting ATLANTIS_API_SECRET to disable these APIs.