Update to be on par with latest mdns.h state#15
Open
talaviram wants to merge 37 commits intogocarlos:masterfrom
Open
Update to be on par with latest mdns.h state#15talaviram wants to merge 37 commits intogocarlos:masterfrom
talaviram wants to merge 37 commits intogocarlos:masterfrom
Conversation
…reduce diffs/formatting.
…c63f182cac2d7a4adc903c)
…ges to support newer mdns.h will be simpler that way.
…red for C++. (#45) 0f28d8ba9049cf7d94c3868b28387d55f2c9a07f
|
Is there any need for "Ignore link-local addresses"? In my use case I search for devices exposed using a default link-local address. |
Author
|
I have no clue :) I’d suggest opening an issue or wondering about this on the mdns.h / C side as it was merged there. |
…commits) 0b4e806bc825335dff79b992b3502ea96d2aafe6
…b88347087b7086772861698193a0a1584
…530287dbfc4f56e6d63e3409080686241bf9
… - 5fdfc32e5b1b2c085012ca2c493e2bd9aa15590a
…ubobject 448f3e5fc9c1d139c4d1744481d0d3c41745fbba
…282900d2e4a1bcfb5b034dc44adc8bda269
…08599b34816b mdns.c - includes dump_callback and dump_dns which are omitted (on this commit) from mdns.cpp updates.
…8ac0a26130aae4a330815c755af7
…70cd146fee392298bdfaf986ce1
…4bb2e4d75963e700ab14e858ac626
…c1ee17b7ae721344925ab
…5a2b736780bbe22108034bc179da65480c76715 but not installing signaling which I guess should be managed by the app running the lib).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've updated mDNS-cpp to be in-sync with changes in mdns c including bug fixes.
I've made it in gradual commits to ensure I'm following actual changes so it might be useful to squash those.
I've compiled and tested it on macOS so I'm sure the Unix side would work for most flavors.
Sadly, I've yet to test the Windows side.I've also pushed relevant changes so now everything was tested on macOS and Windows.