Skip to content

[codex] Fix config update path persistence#35

Merged
wcole1-godaddy merged 2 commits into
mainfrom
codex/fix-config-action-persistence
May 6, 2026
Merged

[codex] Fix config update path persistence#35
wcole1-godaddy merged 2 commits into
mainfrom
codex/fix-config-action-persistence

Conversation

@wcole1-godaddy
Copy link
Copy Markdown
Contributor

Summary

Fixes config update operations so they write back to the exact config file path that was resolved for the update. This prevents godaddy application add action from returning success while leaving the intended OTE TOML unchanged when a specific config path or environment-specific fallback is involved.

Root Cause

addActionToConfigEffect, addSubscriptionToConfigEffect, and addExtensionToConfigEffect resolved a target path, but then discarded that path and wrote through environment-based lookup again. Absolute config paths were also being joined onto process.cwd(), producing invalid duplicated paths in internal callers/tests.

Changes

  • Preserve absolute config paths in getConfigFilePath.
  • Reuse config path resolution for both Effect and sync config reads.
  • Add a path-based config writer for update flows.
  • Update action, subscription, and extension config mutations to write to the resolved path.
  • Add a regression test proving action updates persist to an explicit OTE config file without creating/updating the wrong default file.

Validation

  • pnpm exec tsc --noEmit
  • pnpm run build
  • pnpm test tests/unit/services/config-routing.test.ts
  • pnpm test tests/integration/cli-smoke.test.ts tests/unit/application-deploy-security.test.ts tests/unit/cli/deploy-stream.test.ts
  • rg "export async function" src
  • rg "toEffect|effect-interop" src
  • git diff --check

@wcole1-godaddy wcole1-godaddy marked this pull request as ready for review May 6, 2026 17:27
@wcole1-godaddy wcole1-godaddy merged commit 7b612a9 into main May 6, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant