[codex] Fix config update path persistence#35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes config update operations so they write back to the exact config file path that was resolved for the update. This prevents
godaddy application add actionfrom returning success while leaving the intended OTE TOML unchanged when a specific config path or environment-specific fallback is involved.Root Cause
addActionToConfigEffect,addSubscriptionToConfigEffect, andaddExtensionToConfigEffectresolved a target path, but then discarded that path and wrote through environment-based lookup again. Absolute config paths were also being joined ontoprocess.cwd(), producing invalid duplicated paths in internal callers/tests.Changes
getConfigFilePath.Validation
pnpm exec tsc --noEmitpnpm run buildpnpm test tests/unit/services/config-routing.test.tspnpm test tests/integration/cli-smoke.test.ts tests/unit/application-deploy-security.test.ts tests/unit/cli/deploy-stream.test.tsrg "export async function" srcrg "toEffect|effect-interop" srcgit diff --check