[codex] Use npm trusted publishing for releases#38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NPM_SECRETtoken publishing to npm trusted publishing via GitHub OIDCid-token,contents, andpull-requestspermissions needed by Changesets and npm trusted publishingWhy
The Release workflow failed while publishing
@godaddy/cli@0.5.1with npmE404onPUT https://registry.npmjs.org/@godaddy%2fcli. The package exists on npm, so this points to the CI npm token lacking publish rights for the package/scope.godaddy/javascriptavoids this by using npm trusted publishing: it does not setNPM_TOKEN, grantsid-token: write, and lets npm authenticate the GitHub Actions workflow through OIDC.Follow-up required before merge/release
An npm package owner/admin needs to configure
@godaddy/clion npmjs.com with a trusted publisher for this repository and workflow:godaddyclirelease.yamlmainValidation
.github/workflows/release.yamland.github/workflows/cicd.ymlwith Ruby YAML parser.NPM_SECRETorNPM_TOKEN.