Open
Conversation
rxmarbles
reviewed
Oct 29, 2020
Member
rxmarbles
left a comment
rxmarbles
left a comment
There was a problem hiding this comment.
Theres a bit more that needs to be done to make this component not generate ES2015, we need to remove ES2015 babel plugins would you care to tackle that in this PR as well?
Author
|
@rxmarbles I reconned that the only babel plugin was https://babeljs.io/docs/en/babel-plugin-syntax-dynamic-import I removed it, and also rearranged some configuration accroding to the docs. Leave me a hint of what is missing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Targets #55