Skip to content

fix: Styling fixes for RTL documents and element hover#96

Merged
chinrichs-godaddy merged 1 commit intogodaddy:mainfrom
ali2-godaddy:fix-rtl-issues
Feb 26, 2026
Merged

fix: Styling fixes for RTL documents and element hover#96
chinrichs-godaddy merged 1 commit intogodaddy:mainfrom
ali2-godaddy:fix-rtl-issues

Conversation

@ali2-godaddy
Copy link
Contributor

@ali2-godaddy ali2-godaddy commented Feb 25, 2026

Summary

There are a few bugs that need to be fixed.

1: Carousel cuts off any overflow which causes hover tooltips to not display properly.
2. Specifying text-align left or right causes issues if consumers use webpack-rtl-plugin as this reverts any instances of left to right, and vice versa.

Changelog

1: Fixed issue by specifying overflow y: visible so hover elements can display properly.

Before:
image

After:
image

2: Fixed issue by changing text-align: left to text-align: start which respects document direction attribute.

Before:
image

After:
image

Test Plan

Manual testing and verifying storybook cases.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the carousel’s styling to better support RTL documents and to prevent hover content (e.g., tooltips) from being clipped by the viewport.

Changes:

  • Adjusted .carousel-viewport overflow rules to allow vertical overflow to be visible while still clipping horizontally.
  • Replaced text-align: left/right with text-align: start and removed the RTL-specific text-align override to avoid issues with RTL CSS post-processing.
  • Updated the RTL Storybook story to use text-based slides instead of images.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
src/stories/index.stories.jsx Updates the RTL story’s slide content to better demonstrate RTL text layout.
src/rtl.less Removes RTL-only text-align override for the viewport to avoid left/right flipping conflicts.
src/carousel.less Updates viewport overflow + alignment rules; modifies selected-slide styling.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@chinrichs-godaddy chinrichs-godaddy merged commit c454155 into godaddy:main Feb 26, 2026
3 checks passed
@ali2-godaddy ali2-godaddy deleted the fix-rtl-issues branch February 26, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants