fix: Styling fixes for RTL documents and element hover#96
Merged
chinrichs-godaddy merged 1 commit intogodaddy:mainfrom Feb 26, 2026
Merged
fix: Styling fixes for RTL documents and element hover#96chinrichs-godaddy merged 1 commit intogodaddy:mainfrom
chinrichs-godaddy merged 1 commit intogodaddy:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the carousel’s styling to better support RTL documents and to prevent hover content (e.g., tooltips) from being clipped by the viewport.
Changes:
- Adjusted
.carousel-viewportoverflow rules to allow vertical overflow to be visible while still clipping horizontally. - Replaced
text-align: left/rightwithtext-align: startand removed the RTL-specifictext-alignoverride to avoid issues with RTL CSS post-processing. - Updated the RTL Storybook story to use text-based slides instead of images.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/stories/index.stories.jsx |
Updates the RTL story’s slide content to better demonstrate RTL text layout. |
src/rtl.less |
Removes RTL-only text-align override for the viewport to avoid left/right flipping conflicts. |
src/carousel.less |
Updates viewport overflow + alignment rules; modifies selected-slide styling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1236eb7 to
8318ef6
Compare
8318ef6 to
0489d01
Compare
chinrichs-godaddy
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
There are a few bugs that need to be fixed.
1: Carousel cuts off any overflow which causes hover tooltips to not display properly.
2. Specifying text-align left or right causes issues if consumers use
webpack-rtl-pluginas this reverts any instances of left to right, and vice versa.Changelog
1: Fixed issue by specifying overflow y: visible so hover elements can display properly.
Before:

After:

2: Fixed issue by changing text-align: left to text-align: start which respects document direction attribute.
Before:

After:

Test Plan
Manual testing and verifying storybook cases.