Fix configure test for gcc 14: avoid implicit funcition decl. for main()#33
Open
kk6ho wants to merge 1 commit intogodspeed1989:masterfrom
Open
Fix configure test for gcc 14: avoid implicit funcition decl. for main()#33kk6ho wants to merge 1 commit intogodspeed1989:masterfrom
kk6ho wants to merge 1 commit intogodspeed1989:masterfrom
Conversation
Change the implicit return type of int in the embeded test.c program in
the configure script to explicit "int main()".
This was a warning in previous gcc versions, but in gcc 14 this produces
an error resulting the LIBS variable being empty in the generated
Make.conf, and compile errors due to missing jpeg support, etc.
from bad config.log:
...
infodir = /usr/local/info
$$~test.c:1:1: error: return type defaults to 'int' [-Wimplicit-int]
1 | main()
| ^~~~
libjpeg: no
$$~test.c:1:1: error: return type defaults to 'int' [-Wimplicit-int]
1 | main()
| ^~~~
libpng: no
bmp: yes
fb: /dev/fb0
LIBS =
...
Signed-off-by: Geoff Parker <geoffrey.parker@arthrex.com>
joergneulist
approved these changes
Dec 18, 2025
joergneulist
left a comment
joergneulist
left a comment
There was a problem hiding this comment.
It's a simple change and I arrived at the same solution independently. Looks good!
|
Thank you @kk6ho! I just made the same fix and wanted to place a pull request :-) So I absolutely second merging this, @godspeed1989 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the implicit return type of int in the embeded test.c program in the configure script to explicit "int main()".
This was a warning in previous gcc versions, but in gcc 14 this produces an error resulting the LIBS variable being empty in the generated Make.conf, and compile errors due to missing jpeg support, etc.
from bad config.log:
infodir = /usr/local/info
$$~test.c:1:1: error: return type defaults to 'int' [-Wimplicit-int]
1 | main()
| ^~~~
libjpeg: no
$$~test.c:1:1: error: return type defaults to 'int' [-Wimplicit-int]
1 | main()
| ^~~~
libpng: no
bmp: yes
fb: /dev/fb0
LIBS =
...