ci: allowlist triaged no-fix npm audit advisories#72
Merged
Conversation
next-auth pins nodemailer 7 (no fix), so --audit-level=high left the gate permanently red. Run npm audit through scripts/audit-check.mjs, which allowlists the triaged-unreachable GHSAs but still fails on any new high/critical.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
Dependency audit (npm)check was failing on every PR: a cluster of nodemailer advisories (one high) has no fix available —next-auth's@auth/corepeer-dep pins nodemailer to 7 — sonpm audit --audit-level=highleft the gate permanently red.This routes
npm audit --json --omit=devthroughscripts/audit-check.mjs, which fails on any high/critical advisory except a small, documented allowlist of triaged GHSAs. A genuinely new high/critical still breaks the build.Triage — why these are accepted
All 6 nodemailer advisories are unreachable given
server/email/index.ts:sendEmail()accepts only theEmailPayloadallowlist (from/to/subject/html/text/replyTo) and the transport sets onlyhost/port/secure/auth{user,pass}. So the code never setsenvelope, transportname,List-*headers,raw,jsonTransport, or OAuth2 auth — the vulnerable paths.GHSA-c7w3-x93f-qmm8,GHSA-vvjj-xcjg-gr5g,GHSA-268h-hp4c-crq3,GHSA-wqvq-jvpq-h66f,GHSA-r7g4-qg5f-qqm2,GHSA-p6gq-j5cr-w38fGHSA-qx2v-qp2m-jg93Documented in
CLAUDE.md(Known Issues) anddocs/DECISIONS.md. The allowlist must shrink as fixes land — revisit when next-auth 5 supports nodemailer 8+.Verified
node scripts/audit-check.mjsexits 0 on the current audit (all blocking advisories allowlisted) and exits 1 on a crafted new high — so the gate still catches real regressions.🤖 Generated with Claude Code