fix(net/ghttp): report invalid json body errors#4775
Open
puneetdixit200 wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR improves error propagation for request parameter binding when a request has invalid JSON, and adds a unit test to verify that JSON parse errors are reported instead of falling back to struct validation.
Changes:
- Propagate request parsing errors earlier in
Get*Structhelpers (Request,Query,Form). - Detect JSON body unmarshal failures and surface an invalid-parameter error when
Content-Typeindicates JSON. - Add a unit test covering invalid JSON input and expected error messaging.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| net/ghttp/ghttp_z_unit_feature_request_param_test.go | Adds a controller + test asserting invalid JSON yields a JSON parse error response |
| net/ghttp/ghttp_request_param_request.go | Early-return r.GetError() from request-struct binding |
| net/ghttp/ghttp_request_param_query.go | Early-return r.GetError() from query-struct binding |
| net/ghttp/ghttp_request_param_form.go | Early-return r.GetError() from form-struct binding |
| net/ghttp/ghttp_request_param.go | Sets request error when JSON unmarshal fails for JSON Content-Type |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
00dc94b to
75220dd
Compare
78c73b2 to
3e21639
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Tests: