refactor(compositor): rename input namespace to compositor#135
Merged
Conversation
- Rename all src/compositor/ namespace declarations to goggles::compositor - Update app, UI, and test references to CompositorServer and surface types - Remove staged uses of goggles::input from source and test code - Stage OpenSpec artifacts describing scope, verification, and task breakdown
Review Summary by QodoRename compositor namespace from goggles::input to goggles::compositor
WalkthroughsDescription• Rename goggles::input namespace to goggles::compositor across 18 files • Update compositor module declarations and all qualified references • Enforce project-wide namespace convention matching directory structure • Add comprehensive OpenSpec documentation for design and verification Diagramflowchart LR
A["goggles::input namespace<br/>14 compositor files"] -->|rename| B["goggles::compositor namespace<br/>14 compositor files"]
C["UI forward declaration<br/>imgui_layer.hpp"] -->|update| D["compositor::SurfaceInfo<br/>forward declaration"]
E["Test qualified references<br/>3 test files"] -->|update| F["goggles::compositor::<br/>qualified names"]
B --> G["Namespace convention<br/>enforced uniformly"]
D --> G
F --> G
File Changes1. src/app/application.cpp
|
📝 WalkthroughWalkthroughA mechanical namespace rename from Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
📝 Coding Plan
Comment Tip You can disable poems in the walkthrough.Disable the |
Code Review by Qodo
1. Incorrect file-count spec
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@openspec/changes/archive/2026-03-19-rename-compositor-namespace/spec.md`:
- Around line 137-143: The spec currently contains contradictory and brittle
assertions in the "Scenario: No files created or deleted" section: the lines
asserting "zero files SHALL be created" and "zero files SHALL be deleted"
conflict with this spec file being newly added, and the hardcoded "exactly 18
files SHALL be modified" is brittle. Update that scenario by removing or
relaxing the absolute zero-create/zero-delete claims (or explicitly exempt the
new spec file), and replace the hardcoded "exactly 18 files SHALL be modified"
with a non-brittle description (e.g., "the expected set of files for this
changeset are modified" or parameterized count), editing the section title
"Scenario: No files created or deleted" and the three assertions "zero files
SHALL be created", "zero files SHALL be deleted", and "exactly 18 files SHALL be
modified" accordingly so the statements are consistent and no longer rely on a
fragile fixed number.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 5905efb7-fe22-4c3c-8889-4874744febce
📒 Files selected for processing (25)
openspec/changes/archive/2026-03-19-rename-compositor-namespace/design.mdopenspec/changes/archive/2026-03-19-rename-compositor-namespace/proposal.mdopenspec/changes/archive/2026-03-19-rename-compositor-namespace/spec.mdopenspec/changes/archive/2026-03-19-rename-compositor-namespace/tasks.mdsrc/app/application.cppsrc/app/application.hppsrc/compositor/compositor_core.cppsrc/compositor/compositor_cursor.cppsrc/compositor/compositor_focus.cppsrc/compositor/compositor_input.cppsrc/compositor/compositor_layer_shell.cppsrc/compositor/compositor_present.cppsrc/compositor/compositor_protocol_hooks.hppsrc/compositor/compositor_runtime_metrics.hppsrc/compositor/compositor_server.cppsrc/compositor/compositor_server.hppsrc/compositor/compositor_state.hppsrc/compositor/compositor_targets.hppsrc/compositor/compositor_xdg.cppsrc/compositor/compositor_xwayland.cppsrc/ui/imgui_layer.cppsrc/ui/imgui_layer.hpptests/input/auto_input_forwarding_wayland.cpptests/input/auto_input_forwarding_x11.cpptests/render/test_filter_boundary_contracts.cpp
Comment on lines
+137
to
+143
| ### Scenario: No files created or deleted | ||
|
|
||
| - **GIVEN** the set of files modified by this change | ||
| - **WHEN** the changeset is inspected | ||
| - **THEN** zero files SHALL be created | ||
| - **AND** zero files SHALL be deleted | ||
| - **AND** exactly 18 files SHALL be modified (14 compositor module files, 1 UI forward declaration, 3 test files) |
There was a problem hiding this comment.
Fix contradictory file-change assertions in the spec.
Line 141 and Line 142 conflict with this changeset (this spec file is newly added), and the hardcoded “exactly 18 files” count on Line 143 is brittle for archived documentation.
Proposed spec adjustment
### Scenario: No files created or deleted
-
-- **GIVEN** the set of files modified by this change
-- **WHEN** the changeset is inspected
-- **THEN** zero files SHALL be created
-- **AND** zero files SHALL be deleted
-- **AND** exactly 18 files SHALL be modified (14 compositor module files, 1 UI forward declaration, 3 test files)
+### Scenario: Expected code-scope footprint
+
+- **GIVEN** the namespace-rename implementation scope under `src/` and `tests/`
+- **WHEN** the changeset is inspected
+- **THEN** modifications SHALL be limited to compositor namespace references and related forward declarations/tests
+- **AND** no unrelated functional code changes SHALL be introduced🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@openspec/changes/archive/2026-03-19-rename-compositor-namespace/spec.md`
around lines 137 - 143, The spec currently contains contradictory and brittle
assertions in the "Scenario: No files created or deleted" section: the lines
asserting "zero files SHALL be created" and "zero files SHALL be deleted"
conflict with this spec file being newly added, and the hardcoded "exactly 18
files SHALL be modified" is brittle. Update that scenario by removing or
relaxing the absolute zero-create/zero-delete claims (or explicitly exempt the
new spec file), and replace the hardcoded "exactly 18 files SHALL be modified"
with a non-brittle description (e.g., "the expected set of files for this
changeset are modified" or parameterized count), editing the section title
"Scenario: No files created or deleted" and the three assertions "zero files
SHALL be created", "zero files SHALL be deleted", and "exactly 18 files SHALL be
modified" accordingly so the statements are consistent and no longer rely on a
fragile fixed number.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Release Notes
Documentation
Refactor