Add hammy reader assertions#4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
io.Readercontents (string/bytes) and emptiness using the same style as existing buffer assertions.io.Readerand by reusing a buffered copy for repeated assertions.Description
Reader(actual io.Reader) *ReaderAssertand aReaderAsserttype inhammy/reader.gowith methodsEqualToString,ContainsString,EqualToBytes,IsEmpty, andNotEmptyimplemented to returnAssertionMessageresults.readAllhelper that reads and caches the reader body on first use, returns clear failure messages for nil readers and read errors, and reuses the cached body for subsequent assertions.hammy/reader_test.gowith tests covering success and failure cases for each assertion, nil-reader and read-error handling, and verification that the buffered body is reused after the first read.Testing
go test ./...and all tests passed successfully.Codex Task