Use eye.Spy for assertion failure checks and remove requireFailure helpers#8
Merged
nfisher merged 1 commit intoJun 16, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
requireFailurehelper with the existingeye.Spytest spy for clearer intent and better integration withhammyassertions.Description
github.com/gogunit/gunit/eyeimports tohttpassert_test.go,jsonassert_test.go, andyamlassert_test.goand removed therequireFailurehelper functions from those files.requireFailure(t, result, "...")with the spy pattern:aSpy := eye.Spy(); assert := hammy.New(aSpy); assert.Is(result); aSpy.HadErrorContaining(t, "...")to assert failure messages.stringswhere applicable) and cleaned up the test files accordingly.Testing
go test ./...across the repository and the test suite completed successfully.eye.Spyand passed when run under the test command.Codex Task