Skip to content

v0.1.1#2

Open
alexandro-rezakhani wants to merge 7 commits into
golluroSICKAG:mainfrom
alexandro-rezakhani:main
Open

v0.1.1#2
alexandro-rezakhani wants to merge 7 commits into
golluroSICKAG:mainfrom
alexandro-rezakhani:main

Conversation

@alexandro-rezakhani

Copy link
Copy Markdown

Version x1.0.1
Set Ethernet/IP config
...
Improvements
...
Bugfix
...
Following tasks were checked
[ x] Module is coded and structured according to the "Developing guideline for modules" described within the CSK documentation
[ x] All functions/events/parameters are documented within the manifest documentation
[x ] The manifest description of the main CROWN includes main information about the purpose of the module and how to use it in general
[x ] API docu based on the manifest was created and stored within the "docu"-folder of the repository
[x ] Internal LUA code documentation exists for variables and non served functions
[x ] All relevant infos are logged via the SharedLogger 'ModuleLogger'
[x ] Module supports persistent data feature based on 'CSK_Module_PersistentData'
[x ] Module supports user management based on 'CSK_Module_UserManagement'
[ x] No open "ToDos" within the code or at least clearly explained comments why they exist...
[ x] "Version" key in app manifest was updated following semantic versioning (and use '0.x.y' for test / experimental modules which are not yet ready to be officially released)
[x ] Meaningful IDs used for UI elements
[ x] Module was tested on an AppSpace device (at least on SICK AppEngine) with no error message
[ x] README.md is up to date (incl. info of device + firmware the module was tested with)
[x ] CHANGELOG.md is up to date

Tested both fieldbuses and quickly read and wrote control bits.
Updated description and included latest test unit information.
@golluroSICKAG

Copy link
Copy Markdown
Owner

Thx for your contribution!
I tried to merge it with some other updates within:
https://github.com/golluroSICKAG/CSK_Module_Fieldbus/tree/941409cd008dca7494951b94fdeaf34b7eb8d1b6

Not tested yet but will try to do it in next week.

But please check the variables "netmask2" and "gateway2" as it seems they are not used?

@alexandro-rezakhani

Copy link
Copy Markdown
Author

Thx for your contribution! I tried to merge it with some other updates within: https://github.com/golluroSICKAG/CSK_Module_Fieldbus/tree/941409cd008dca7494951b94fdeaf34b7eb8d1b6

Not tested yet but will try to do it in next week.

But please check the variables "netmask2" and "gateway2" as it seems they are not used?

ipaddress2, netmask2 and gateway2 are being used as backups when an invalid entry is used. The script checks if the IP and gateway addresses are within the same subnet and if they are not the old valid entry is saved. The expectation is the user will assign the gateway to be within the same subnet after setting an IP outside of the range.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants