Rename to go-darwinml and restructure for multi-backend support#13
Open
ajroetker wants to merge 1 commit intogomlx:mainfrom
Open
Rename to go-darwinml and restructure for multi-backend support#13ajroetker wants to merge 1 commit intogomlx:mainfrom
ajroetker wants to merge 1 commit intogomlx:mainfrom
Conversation
Move CoreML-specific packages (model/, runtime/, internal/bridge/) under coreml/ to match the existing mpsgraph/ layout, making each backend symmetric. Rename the module from github.com/gomlx/go-coreml to github.com/gomlx/go-darwinml to reflect the multi-backend scope. Also updates mpsgraph FusedScaledDotProductAttention to match the upstream gomlx interface change (added options parameter).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github.com/gomlx/go-coremltogithub.com/gomlx/go-darwinmlmodel/,runtime/,internal/bridge/,gomlx/) undercoreml/to matchmpsgraph/layoutgo_packageoptions, and regenerate.pb.gofilesmpsgraph/gomlxtogo.workso all backends are in the workspaceFusedScaledDotProductAttentionsignature to match upstream gomlx API changeThe repo is becoming a multi-backend project (CoreML, MPSGraph, future AMX), so the structure and naming should reflect that. Each backend now lives symmetrically under its own top-level directory:
Test plan
go test github.com/gomlx/go-darwinml/...— all pass