Change Graph.Compile to return an error instead of panicking#397
Open
janpfeifer wants to merge 1 commit intomainfrom
Open
Change Graph.Compile to return an error instead of panicking#397janpfeifer wants to merge 1 commit intomainfrom
janpfeifer wants to merge 1 commit intomainfrom
Conversation
Updated all call sites, mostly in tests, to handle the error returned by Compile and CompileWithSharding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates 'Graph.Compile' and 'Graph.CompileWithSharding' to return an error instead of panicking, allowing for more robust error handling during graph compilation. It also includes corresponding updates to call sites across various test files.