Reworked to use gooddata-http-client 3.0.0 #1218
Merged
Conversation
Signed-off-by: Dmitrii Puzikov <dmitrii.puzikov@gooddata.com>
There was a problem hiding this comment.
Pull request overview
This pull request migrates the codebase to use gooddata-http-client:3.0.0, which involves upgrading from Apache HTTP 4 to Apache HTTP 5 Classic API. The changes are primarily code formatting and style improvements, with the actual HTTP client migration work happening in dependencies.
Key Changes:
- Removal of trailing blank lines from numerous Java source files
- Reorganization of import statements to follow standard ordering (external imports, then internal imports, then static imports)
- Repositioning of methods within classes to improve organization
- Formatting improvements for code readability
Reviewed changes
Copilot reviewed 293 out of 1032 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Multiple warehouse model files | Removed trailing blank lines and reordered imports |
| Multiple project model files | Reordered imports, removed trailing blank lines, and repositioned methods |
| Multiple notification files | Import reorganization and trailing blank line removal |
| Multiple metadata files | Import reorganization, method reordering, and formatting cleanup |
| Multiple executeafm files | Import reorganization, javadoc formatting, and trailing blank line removal |
| Multiple connector files | Method reordering, import cleanup, and trailing blank line removal |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
757d025 to
9a4e04d
Compare
jiri-staroba
approved these changes
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now using
gooddata-http-client:3.0.0thusmigrated to Apache Http5 Classic API
Http4 kept to be used by Sardine WebDAV client.