fix: use urllib3 headers API and require >=2.6.1#1256
Closed
fix: use urllib3 headers API and require >=2.6.1#1256
Conversation
rhefner1
requested review from
hkad98,
jaceksan,
lupko and
pcerny
as code owners
rhefner1
force-pushed
the
rhef/urllib-bump
branch
2 times, most recently
from
4569c9e to
ad23718
Compare
urllib3 2.6.0 removed HTTPResponse.getheader/getheaders (which were already deprecated shims), which made RESTResponse crash with AttributeError. Switch to headers.get/headers and also pin urllib3 to 2.6.1+.
rhefner1
force-pushed
the
rhef/urllib-bump
branch
from
ad23718 to
6c44b17
Compare
Contributor
|
Unfortunately, this will not work because gooddata-api-client is generated from OAPI schemas. |
Contributor
|
I preapred an update of gooddata-api-client in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
urllib3 2.6.0 removed HTTPResponse.getheader/getheaders (which were already deprecated shims), which made RESTResponse crash with AttributeError. Switch to headers.get/headers and also pin urllib3 to 2.6.1+.