fix: resolve tox not found error make test from package directories#1276
Closed
tuan-tran-thanh wants to merge 1 commit intogooddata:masterfrom
Closed
fix: resolve tox not found error make test from package directories#1276tuan-tran-thanh wants to merge 1 commit intogooddata:masterfrom
tuan-tran-thanh wants to merge 1 commit intogooddata:masterfrom
Conversation
…directories The tox dependency group is defined in the workspace root's pyproject.toml, but uv run tox from package directories couldn't access it. This fix: - Syncs the workspace root with the tox dependency group to ensure tox is installed in the root's .venv - Runs tox directly from the root's .venv/bin/tox instead of using uv run, which allows it to find the correct tox.ini in the package directory while using the workspace-level tox installation This resolves the 'Failed to spawn: tox' error when running make test from individual package directories like packages/gooddata-sdk. JIRA: TRIVIAL risk: nonprod
tuan-tran-thanh
requested review from
hkad98,
jaceksan,
lupko and
pcerny
as code owners
tuan-tran-thanh
changed the title
hkad98
reviewed
Jan 23, 2026
| .PHONY: mypy | ||
| mypy: | ||
| uv run tox $(TOX_FLAGS) -e mypy | ||
| (cd $(ROOT_DIR); uv sync --group tox > /dev/null 2>&1) && $(ROOT_DIR)/.venv/bin/tox $(TOX_FLAGS) -e mypy |
Contributor
There was a problem hiding this comment.
Consider using the .venv created and populated during make dev. Installing dependencies at runtime is non-optimal and is also a side effect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tox dependency group is defined in the workspace root's pyproject.toml, but uv run tox from package directories couldn't access it. This fix:
This resolves the 'Failed to spawn: tox' error when running make test from individual package directories like packages/gooddata-sdk.
JIRA: TRIVIAL
risk: nonprod