Conversation
Contributor
alexole01
commented
Jan 14, 2025
alexole01
commented
alexole01
force-pushed
the
aole-gooddata-rest-common
branch
from
12dcbfa to
432ec2f
Compare
Contributor
Author
|
BREAKING CHANGE: gooddata-rest-common - upgrade to jdk17, spring6, springboot3. |
Contributor
Author
|
please review |
|
LGTM |
petr-klemsinsky
previously requested changes
Feb 7, 2025
petr-klemsinsky
left a comment
petr-klemsinsky
left a comment
There was a problem hiding this comment.
Please update commit message to conform Conventional commits and https://gooddata.atlassian.net/wiki/spaces/pap/pages/1720778756/Commit+Message+Guideline.
alexole01
force-pushed
the
aole-gooddata-rest-common
branch
2 times, most recently
from
abef5c4 to
42f66d2
Compare
alexole01
force-pushed
the
aole-gooddata-rest-common
branch
from
02326f9 to
f9b9815
Compare
xvalovic
approved these changes
Feb 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.