Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copied over from #336 with the new
devbase branch.Description
Add global CI function mode as an alternative to the existing layerwise CI functions.
Key changes:
LayerwiseCiConfig | GlobalCiConfig) for CI function configurationGlobalSharedMLPCiFnthat concatenates activations across all layers, processes through a shared MLP, and splits outputs back to per-layer CI valuesLayerwiseCiFnWrapper,GlobalCiFnWrapper) that provide a consistent interface regardless of CI modeci_configformatRelated Issue
N/A
Motivation and Context
The existing layerwise CI functions learn separate importance functions per layer, which limits parameter sharing and may miss cross-layer patterns. Global CI provides an alternative where a single network sees all layer activations simultaneously, enabling:
How Has This Been Tested?
Does this PR introduce a breaking change?
Yes. Checkpoints from before this PR are incompatible due to:
ci_fn_type/ci_fn_hidden_dimsto nestedci_configdiscriminated unionci_fn._ci_fnsorci_fn._global_ci_fn)New canonical runs have been created to replace the old ones.
New Canonical Runs