Skip to content

test(hw04): add controller tests and extract shared test helpers #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
goodman74 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test(hw04): add controller tests and extract shared test helpers #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Homeworks/04 Добавление юнит тестов/src/PromoCodeFactory.DataAccess/.editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@

[*.cs]
csharp_style_namespace_declarations = block_scoped:silent
46 changes: 6 additions & 40 deletions ...ит тестов/src/PromoCodeFactory.UnitTests/WebHost/Controllers/Partners/CancelLimitTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
using PromoCodeFactory.Core.Domain.Administration;
using PromoCodeFactory.Core.Domain.PromoCodeManagement;
using PromoCodeFactory.Core.Exceptions;
using PromoCodeFactory.UnitTests.WebHost.Controllers.Partners.Shared;
using PromoCodeFactory.WebHost.Controllers;
using Soenneker.Utils.AutoBogus;

Expand Down Expand Up @@ -50,7 +51,7 @@ public async Task CancelLimit_WhenPartnerBlocked_ReturnsUnprocessableEntity()
// Arrange
var partnerId = Guid.NewGuid();
var limitId = Guid.NewGuid();
var partner = CreatePartnerWithLimit(partnerId, limitId, isActive: false);
var partner = PartnerCreater.CreateWithOneActiveLimit(partnerId, limitId, isActive: false);

_partnersRepositoryMock
.Setup(r => r.GetById(partnerId, true, It.IsAny<CancellationToken>()))
Expand All @@ -74,7 +75,7 @@ public async Task CancelLimit_WhenLimitNotFound_ReturnsNotFound()
var partnerId = Guid.NewGuid();
var limitId = Guid.NewGuid();
var otherLimitId = Guid.NewGuid();
var partner = CreatePartnerWithLimit(partnerId, otherLimitId, isActive: true);
var partner = PartnerCreater.CreateWithOneActiveLimit(partnerId, otherLimitId, isActive: true);

_partnersRepositoryMock
.Setup(r => r.GetById(partnerId, true, It.IsAny<CancellationToken>()))
Expand All @@ -97,7 +98,7 @@ public async Task CancelLimit_WhenLimitAlreadyCanceled_ReturnsUnprocessableEntit
// Arrange
var partnerId = Guid.NewGuid();
var limitId = Guid.NewGuid();
var partner = CreatePartnerWithLimit(partnerId, limitId, isActive: true, canceledAt: DateTimeOffset.UtcNow);
var partner = PartnerCreater.CreateWithCanceledLimit(partnerId, limitId, isActive: true, canceledAt: DateTimeOffset.UtcNow);

_partnersRepositoryMock
.Setup(r => r.GetById(partnerId, true, It.IsAny<CancellationToken>()))
Expand All @@ -120,7 +121,7 @@ public async Task CancelLimit_WhenValidRequest_ReturnsNoContentAndUpdatesPartner
// Arrange
var partnerId = Guid.NewGuid();
var limitId = Guid.NewGuid();
var partner = CreatePartnerWithLimit(partnerId, limitId, isActive: true);
var partner = PartnerCreater.CreateWithOneActiveLimit(partnerId, limitId, isActive: true);

_partnersRepositoryMock
.Setup(r => r.GetById(partnerId, true, It.IsAny<CancellationToken>()))
Expand All @@ -147,7 +148,7 @@ public async Task CancelLimit_WhenUpdateThrowsEntityNotFoundException_ReturnsNot
// Arrange
var partnerId = Guid.NewGuid();
var limitId = Guid.NewGuid();
var partner = CreatePartnerWithLimit(partnerId, limitId, isActive: true);
var partner = PartnerCreater.CreateWithOneActiveLimit(partnerId, limitId, isActive: true);

_partnersRepositoryMock
.Setup(r => r.GetById(partnerId, true, It.IsAny<CancellationToken>()))
Expand All @@ -163,39 +164,4 @@ public async Task CancelLimit_WhenUpdateThrowsEntityNotFoundException_ReturnsNot
// Assert
result.Should().BeOfType<NotFoundResult>();
}

private static Partner CreatePartnerWithLimit(
Guid partnerId,
Guid limitId,
bool isActive,
DateTimeOffset? canceledAt = null)
{
var role = new AutoFaker<Role>()
.RuleFor(r => r.Id, _ => Guid.NewGuid())
.Generate();

var employee = new AutoFaker<Employee>()
.RuleFor(e => e.Id, _ => Guid.NewGuid())
.RuleFor(e => e.Role, role)
.Generate();

var limits = new List<PartnerPromoCodeLimit>();
var partner = new AutoFaker<Partner>()
.RuleFor(p => p.Id, _ => partnerId)
.RuleFor(p => p.IsActive, _ => isActive)
.RuleFor(p => p.Manager, employee)
.RuleFor(p => p.PartnerLimits, limits)
.Generate();

var limit = new AutoFaker<PartnerPromoCodeLimit>()
.RuleFor(l => l.Id, _ => limitId)
.RuleFor(l => l.Partner, partner)
.RuleFor(l => l.CanceledAt, _ => canceledAt)
.RuleFor(l => l.CreatedAt, _ => DateTimeOffset.UtcNow.AddDays(-1))
.RuleFor(l => l.EndAt, _ => DateTimeOffset.UtcNow.AddDays(30))
.Generate();

limits.Add(limit);
return partner;
}
}
209 changes: 209 additions & 0 deletions ...ит тестов/src/PromoCodeFactory.UnitTests/WebHost/Controllers/Partners/CreateLimitTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,209 @@
using AwesomeAssertions;
using Bogus;
using Microsoft.AspNetCore.Mvc;
using Microsoft.AspNetCore.Routing;
using Moq;
using PromoCodeFactory.Core.Abstractions.Repositories;
using PromoCodeFactory.Core.Domain.PromoCodeManagement;
using PromoCodeFactory.Core.Exceptions;
using PromoCodeFactory.UnitTests.WebHost.Controllers.Partners.Shared;
using PromoCodeFactory.WebHost.Controllers;
using PromoCodeFactory.WebHost.Mapping;
using PromoCodeFactory.WebHost.Models.Partners;

namespace PromoCodeFactory.UnitTests.WebHost.Controllers.Partners;

public class CreateLimitTests
{
private readonly Mock<IRepository<Partner>> _partnersRepositoryMock;
private readonly Mock<IRepository<PartnerPromoCodeLimit>> _partnerLimitsRepositoryMock;
private readonly CancellationToken _ctNone = CancellationToken.None;
private readonly PartnersController _controller;

public CreateLimitTests()
{
_partnersRepositoryMock = new Mock<IRepository<Partner>>();
_partnerLimitsRepositoryMock = new Mock<IRepository<PartnerPromoCodeLimit>>();
_controller = new PartnersController(_partnersRepositoryMock.Object, _partnerLimitsRepositoryMock.Object);
}

[Fact]
public async Task CreateLimit_WhenPartnerNotFound_ReturnsNotFound()
{
// Arrange
var partnerId = Guid.NewGuid();
const int limit = 1;
var request = new PartnerPromoCodeLimitCreateRequest(DateTime.UtcNow, limit);

Partner? returnedPartner = null;

_partnersRepositoryMock
.Setup(x => x.GetById(partnerId, withIncludes: true, _ctNone))
.ReturnsAsync(returnedPartner);

// Act
var result = await _controller.CreateLimit(partnerId, request, _ctNone);

// Assert
var notFound = result.Result.Should().BeOfType<NotFoundObjectResult>().Subject;
var problemDetails = notFound.Value.Should().BeOfType<ProblemDetails>().Subject;
problemDetails.Title.Should().Be("Partner not found");

_partnersRepositoryMock.Verify(x => x.Update(It.IsAny<Partner>(), _ctNone), Times.Never);
_partnerLimitsRepositoryMock.Verify(x => x.Add(It.IsAny<PartnerPromoCodeLimit>(),_ctNone), Times.Never);
}

[Fact]
public async Task CreateLimit_WhenPartnerBlocked_ReturnsUnprocessableEntity()
{
// Arrange
var partnerId = Guid.NewGuid();
const int limit = 1;
var request = new PartnerPromoCodeLimitCreateRequest(DateTime.UtcNow, limit);

var returnedPartner = PartnerCreater.Create(partnerId, isActive: false);

_partnersRepositoryMock
.Setup(x => x.GetById(partnerId, withIncludes: true, _ctNone))
.ReturnsAsync(returnedPartner);

// Act
var result = await _controller.CreateLimit(partnerId, request, _ctNone);

// Assert
var unprocessable = result.Result.Should().BeOfType<UnprocessableEntityObjectResult>().Subject;
var problemDetails = unprocessable.Value.Should().BeOfType<ProblemDetails>().Subject;
problemDetails.Title.Should().Be("Partner blocked");

_partnersRepositoryMock.Verify(x => x.Update(It.IsAny<Partner>(), _ctNone), Times.Never);
_partnerLimitsRepositoryMock.Verify(x => x.Add(It.IsAny<PartnerPromoCodeLimit>(), _ctNone), Times.Never);
}

[Fact]
public async Task CreateLimit_WhenValidRequest_ReturnsCreatedAndAddsLimit()
{
// Arrange
var partnerId = Guid.NewGuid();
var newLimit = new Randomizer().Int(1, 10);
var endAtLimits = DateTime.UtcNow.AddDays(1);

var request = new PartnerPromoCodeLimitCreateRequest(endAtLimits, newLimit);

var returnedPartnerWithoutActiveLimits = PartnerCreater.Create(partnerId, isActive: true);

PartnerPromoCodeLimit? newPartnerPromoCodeLimit = null;

_partnersRepositoryMock
.Setup(x => x.GetById(partnerId, withIncludes: true, _ctNone))
.ReturnsAsync(returnedPartnerWithoutActiveLimits);

_partnerLimitsRepositoryMock
.Setup(x => x.Add(It.IsAny<PartnerPromoCodeLimit>(), _ctNone))
.Callback<PartnerPromoCodeLimit, CancellationToken>((limit, _) => newPartnerPromoCodeLimit = limit);

// Act
var result = await _controller.CreateLimit(partnerId, request, _ctNone);

// Assert
var created = result.Result.Should().BeOfType<CreatedAtActionResult>().Subject;

created.ActionName.Should().Be("GetLimit");

newPartnerPromoCodeLimit.Should().NotBeNull();
newPartnerPromoCodeLimit.Limit.Should().Be(newLimit);
newPartnerPromoCodeLimit.EndAt.Should().Be(endAtLimits);

var routeDict = created.RouteValues.Should().BeOfType<RouteValueDictionary>().Subject;
routeDict["partnerId"].Should().Be(partnerId);
routeDict["limitId"].Should().Be(newPartnerPromoCodeLimit.Id);

var obj = created.Value.Should().BeOfType<PartnerPromoCodeLimitResponse>().Subject;
obj.Should().BeEquivalentTo(PartnersMapper.ToPartnerPromoCodeLimitResponse(newPartnerPromoCodeLimit));
}

[Fact]
public async Task CreateLimit_WhenValidRequestWithActiveLimit_CancelsOldLimitsAndAddsNew()
{
// Arrange
var partnerId = Guid.NewGuid();
var limitId = Guid.NewGuid();
var returnedPartnerWithActiveLimit = PartnerCreater.CreateWithOneActiveLimit(partnerId, limitId, isActive: true);

var newLimit = new Randomizer().Int(1, 10);
var endAtLimits = DateTime.UtcNow.AddDays(1);

var request = new PartnerPromoCodeLimitCreateRequest(endAtLimits, newLimit);

PartnerPromoCodeLimit? newPartnerPromoCodeLimit = null;
Partner? updatedPartner = null;

_partnersRepositoryMock
.Setup(x => x.GetById(partnerId, withIncludes: true, _ctNone))
.ReturnsAsync(returnedPartnerWithActiveLimit);

_partnersRepositoryMock
.Setup(x => x.Update(It.IsAny<Partner>(), _ctNone))
.Callback<Partner, CancellationToken>((partner, _) => updatedPartner = partner);

_partnerLimitsRepositoryMock
.Setup(x => x.Add(It.IsAny<PartnerPromoCodeLimit>(), _ctNone))
.Callback<PartnerPromoCodeLimit, CancellationToken>((limit, _) => newPartnerPromoCodeLimit = limit);

// Act
var result = await _controller.CreateLimit(partnerId, request, _ctNone);

// Assert
updatedPartner.Should().NotBeNull();
updatedPartner.PartnerLimits.Should().OnlyContain(l => l.CanceledAt != null);

var created = result.Result.Should().BeOfType<CreatedAtActionResult>().Subject;

created.ActionName.Should().Be("GetLimit");

newPartnerPromoCodeLimit.Should().NotBeNull();
newPartnerPromoCodeLimit.Limit.Should().Be(newLimit);
newPartnerPromoCodeLimit.EndAt.Should().Be(endAtLimits);
newPartnerPromoCodeLimit!.CanceledAt.Should().BeNull();

var routeDict = created.RouteValues.Should().BeOfType<RouteValueDictionary>().Subject;
routeDict["partnerId"].Should().Be(partnerId);
routeDict["limitId"].Should().Be(newPartnerPromoCodeLimit.Id);

var obj = created.Value.Should().BeOfType<PartnerPromoCodeLimitResponse>().Subject;
obj.Should().BeEquivalentTo(PartnersMapper.ToPartnerPromoCodeLimitResponse(newPartnerPromoCodeLimit));

_partnersRepositoryMock.Verify(x => x.Update(It.IsAny<Partner>(), _ctNone), Times.Once);
_partnerLimitsRepositoryMock.Verify(x => x.Add(It.IsAny<PartnerPromoCodeLimit>(), _ctNone), Times.Once);
}

[Fact]
public async Task CreateLimit_WhenUpdateThrowsEntityNotFoundException_ReturnsNotFound()
{
// Arrange
var partnerId = Guid.NewGuid();
var limitId = Guid.NewGuid();
var returnedPartnerWithActiveLimit = PartnerCreater.CreateWithOneActiveLimit(partnerId, limitId, isActive: true);

var newLimit = new Randomizer().Int(1, 10);
var endAtLimits = DateTime.UtcNow.AddDays(1);

var request = new PartnerPromoCodeLimitCreateRequest(endAtLimits, newLimit);

_partnersRepositoryMock
.Setup(x => x.GetById(partnerId, withIncludes: true, _ctNone))
.ReturnsAsync(returnedPartnerWithActiveLimit);

_partnersRepositoryMock
.Setup(x => x.Update(It.IsAny<Partner>(), _ctNone))
.ThrowsAsync(new EntityNotFoundException<Partner>(partnerId));

// Act
var result = await _controller.CreateLimit(partnerId, request, _ctNone);

// Assert
result.Result.Should().BeOfType<NotFoundResult>();

_partnersRepositoryMock.Verify(x => x.Update(It.IsAny<Partner>(), _ctNone), Times.Once);
_partnerLimitsRepositoryMock.Verify(x => x.Add(It.IsAny<PartnerPromoCodeLimit>(), _ctNone), Times.Never);
}
}
29 changes: 0 additions & 29 deletions ... юнит тестов/src/PromoCodeFactory.UnitTests/WebHost/Controllers/Partners/SetLimitTests.cs
View file
Open in desktop

This file was deleted.

Loading