Skip to content
This repository was archived by the owner on Sep 14, 2021. It is now read-only.

Camera projection matrix to camera FOV conversion#483

Open
dnnkeeper wants to merge 1 commit into
google-ar:masterfrom
dnnkeeper:camera-projection-fix
Open

Camera projection matrix to camera FOV conversion#483
dnnkeeper wants to merge 1 commit into
google-ar:masterfrom
dnnkeeper:camera-projection-fix

Conversation

@dnnkeeper
Copy link
Copy Markdown

I encountered issue with adding Unity Post-Processing effects stack to arcore sample project: cameras field of view was overriden when postprocessing effects was enabled. So I discovered culprit of this problem: ARCoreBackgroundRenderer was controlling FOV of the main camera using projection matrix instead of Unity Camera FOV parameter. So I managed to extract FOV value from arcore projection matrix and set it directly.

@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@dnnkeeper
Copy link
Copy Markdown
Author

I signed it!

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants