Skip to content
This repository was archived by the owner on Sep 14, 2021. It is now read-only.

Fixing issue where the Object Manipulation example fails in Unity 2018.3#501

Open
small-potatoes wants to merge 1 commit into
masterfrom
fix-2018-3-manipulation-system-bug
Open

Fixing issue where the Object Manipulation example fails in Unity 2018.3#501
small-potatoes wants to merge 1 commit into
masterfrom
fix-2018-3-manipulation-system-bug

Conversation

@small-potatoes
Copy link
Copy Markdown

Fixing issue where the Object Manipulation example fails in Unity 2018.3 due to the order of calls to OnEnable and OnAwake (1) being different than previous versions of the editor and (2) exposing an initialization bug in ManipulationSystem.cs. This commit refactors ManipulationSystem.cs to allow access to static member ManipulationSystem.Instance before any calls to non-static member Awake.

@googlebot
Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

Googlers can find more info about SignCLA and this PR by following this link.

@small-potatoes small-potatoes force-pushed the fix-2018-3-manipulation-system-bug branch 2 times, most recently from 6ea06ba to e3a518c Compare February 16, 2019 05:05
@small-potatoes
Copy link
Copy Markdown
Author

Run again.

…8.3 due to the order of calls to OnEnable and OnAwake (1) being different than previous versions of the editor and (2) exposing an initialization bug in ManipulationSystem.cs. This commit refactors ManipulationSystem.cs to allow access to static member ManipulationSystem.Instance before any calls to non-static member Awake.
@small-potatoes small-potatoes force-pushed the fix-2018-3-manipulation-system-bug branch from e3a518c to 0d6bcd3 Compare February 16, 2019 05:17
@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

Googlers can find more info about SignCLA and this PR by following this link.

@fredsa
Copy link
Copy Markdown

fredsa commented Feb 20, 2019

Fixes #502

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants