docker: update Python Docker SDK dependency#1130
Open
francdoc wants to merge 1 commit into
Open
Conversation
Update the Python Docker SDK used by run_docker.py from 5.0.0 to 7.1.0. Newer Docker/Python dependency stacks can fail before the container starts with errors such as an unsupported http+docker URL scheme.\n\nThe launcher still imports successfully with docker 7.1.0 and the Docker SDK types used by run_docker.py remain available.\n\nFixes google-deepmind#1066.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1066.
Hi,
docker/run_docker.pydepends on the Python Docker SDK, butdocker/requirements.txtstill pinsdocker==5.0.0. Newer Docker/Python dependency stacks can fail before the container starts with errors such as an unsupportedhttp+dockerURL scheme. As seen in #1066.This PR updates the Python Docker SDK dependency to
docker==7.1.0. The launcher still imports successfully with this version and the Docker SDK types used byrun_docker.pyremain available.Validation:
git diff --checkpython -m pip install -r docker/requirements.txtpython -m py_compile docker/run_docker.pydocker==7.1.0exposesdocker.types.Mountanddocker.types.DeviceRequestNot performed: