Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
Just signed the CLA. PTAL |
Author
|
Hi @charlesbeattie and @Augustin-Zidek , would you mind taking a look at this PR? I'm adding a functionality for S3. |
|
I recommend that you use --- a/src/file/file_systems/s3/s3_file_system.cc
+++ b/src/file/file_systems/s3/s3_file_system.cc
@@ -22,6 +22,7 @@
#include <vector>
#include "absl/algorithm/container.h"
+#include "absl/base/call_once.h"
#include "absl/base/no_destructor.h"
#include "absl/base/nullability.h"
#include "absl/functional/function_ref.h"
@@ -217,12 +218,11 @@ std::shared_ptr<Aws::S3::S3Client> S3FileSystem::Client() const {
ClientFactory client_factory = client_factory_;
if (client_factory == nullptr) {
client_factory = [] {
- static Aws::SDKOptions options;
- static bool initialized = false;
- if (!initialized) {
+ static absl::once_flag aws_init_once;
+ absl::call_once(aws_init_once, []() {
+ static Aws::SDKOptions options;
Aws::InitAPI(options);
- initialized = true;
- }
+ });
return std::make_shared<Aws::S3::S3Client>();
};
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to use the S3, add a S3 filesystem similar to the GCS one. The S3 client and the APIs like GetObject are also applied similar to the GCS one. Tested with my S3 bucket and it works with both integrity and good efficiency.