[pmap] Make clrs nets.py _get_first more robust under jax_pmap_shmap_merge#177
Closed
copybara-service[bot] wants to merge 0 commit intomasterfrom
Closed
[pmap] Make clrs nets.py _get_first more robust under jax_pmap_shmap_merge#177copybara-service[bot] wants to merge 0 commit intomasterfrom
copybara-service[bot] wants to merge 0 commit intomasterfrom
Conversation
e9d2d5a to
f13a1b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[pmap] Make clrs nets.py _get_first more robust under jax_pmap_shmap_merge
With jax_pmap_shmap_merge=True, the code in nets.py's NetChunked.call
was calling addressable_shards on inputs and hints without checking if they
are JAX arrays first. When numpy arrays are passed (e.g., during init), this
causes AttributeError.
This fix adds a robust _get_first helper that:
extracts data from replicated shards