Skip to content

Broken error messages in token normalization—{token!r} shown literally instead of actual token value (#579) #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
markknoffler wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Broken error messages in token normalization—{token!r} shown literally instead of actual token value (#579) #580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gemma/gm/text/_sampler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -572,7 +572,7 @@ def _normalize_token(tokenizer, token: str | int) -> int:
token_id = tokenizer.encode(token)
if len(token_id) != 1:
raise ValueError(
'Invalid token: {token!r}. `stop_token`s and `forbidden_token`s must'
f'Invalid token: {token!r}. `stop_token`s and `forbidden_token`s must'
' map to single token ids in the vocab.'
)
(token_id,) = token_id
Expand Down
2 changes: 1 addition & 1 deletion gemma/research/t5gemma/sampling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -510,7 +510,7 @@ def _normalize_token(tokenizer, token: str | int) -> int:
token_id = tokenizer.encode(token)
if len(token_id) != 1:
raise ValueError(
'Invalid forbidden token: {token!r}. Forbidden tokens must map to'
f'Invalid forbidden token: {token!r}. Forbidden tokens must map to'
' single token ids in the vocab.'
)
(token_id,) = token_id
Expand Down