Skip to content

fix(utils): download tokenizer models locally via HTTP to avoid TF GCS C++ segfault on macOS #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
prince-shakyaa wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(utils): download tokenizer models locally via HTTP to avoid TF GCS C++ segfault on macOS #661

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions gemma/gm/utils/_file_cache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,24 @@ def maybe_get_from_cache(
remote_file_path: epath.PathLike,
cache_subdir: str,
) -> epath.Path:
"""Returns the cached file if exists, otherwise returns the remote file path."""
filename = epath.Path(remote_file_path).name
"""Returns the cached file if exists, otherwise downloads it and returns local path."""
remote_path_str = str(remote_file_path)
filename = epath.Path(remote_path_str).name

cache_filepath = _get_cache_dir() / cache_subdir / filename
cache_dir = _get_cache_dir() / cache_subdir
cache_filepath = cache_dir / filename
if cache_filepath.exists():
return cache_filepath

if remote_path_str.startswith('gs://'):
cache_dir.mkdir(parents=True, exist_ok=True)
http_url = remote_path_str.replace('gs://', 'https://storage.googleapis.com/')
print(f"Downloading {filename} to {cache_filepath}...")

import urllib.request
urllib.request.urlretrieve(http_url, str(cache_filepath))
return cache_filepath

return epath.Path(remote_file_path)


Expand Down