Skip to content

Flip default freeze to False in konfig.resolve and remove ImmutableDict. #664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Flip default freeze to False in konfig.resolve and remove ImmutableDict. #664

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions gemma/gm/evals/_sample.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
import jax
from kauldron import kd
from kauldron.utils import config_util
from kauldron.utils import immutabledict
from kauldron.utils import utils


Expand Down Expand Up @@ -78,10 +77,6 @@ class SamplerEvaluator(kd.evals.EvaluatorBase):
default_factory=dict
)

def __post_init__(self):
super().__post_init__()
immutabledict.freeze_dict_attrs(self, ['losses', 'metrics', 'summaries'])

def evaluate(self, state: kd.train.TrainState, step: int) -> Any:
"""Run this evaluator then write and optionally return the results."""
self._assert_root_cfg_resolved()
Expand Down
5 changes: 1 addition & 4 deletions gemma/gm/text/_tokenizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,9 @@
from gemma.gm.utils import _file_cache
import jax
import jax.numpy as jnp
from kauldron.utils import immutabledict
import numpy as np


from sentencepiece import sentencepiece_model_pb2
import sentencepiece as spm

Expand Down Expand Up @@ -196,9 +196,6 @@ class Tokenizer:
FORMAT: ClassVar[dialog.Format] = dialog.Format.GEMMA3
FORMAT_TO_CONVERT: ClassVar[dialog.Format | None] = None

def __post_init__(self):
immutabledict.freeze_dict_attrs(self, ['custom_tokens'])

@classmethod
def from_version(cls, version: int | str) -> Tokenizer:
"""Create a tokenizer from a version."""
Expand Down
Loading