Fix imas loader test due to new imas-python tag#1846
Conversation
There was a problem hiding this comment.
2.1.0 isn't released from what I can tell at https://github.com/iterorganization/IMAS-Python. Is this a private version that you are using?
|
I think there is just this tag for now https://github.com/iterorganization/IMAS-Python/releases/tag/2.1.0-post1. It triggered a version change for the version use in the pipeline I guess, gave failures when I committed on #1630 |
|
Ah interesting, we need to import the library but I think there is a small issue with the release that prevents our tests from running without imas-core that I've raised iterorganization/IMAS-Python#88. For now I'm proposing restricting to use 2.0.1, is that suitable for your use case? |
|
Yes it perfectly fine for me I think every feature should work fine with 2.0.1 for now ! |
Awesome, thanks Mateo :) |
|
Hey Mateo, sorry for the wait on this. Just an update, we're looking to add imas_core to our deps so should be able to bring this in soon. |
|
great happy to hear that ! Don't worry for the wait there is no hurry on this :) |
|
I'm actually going to close this as we'll be forced to make this change internally when we do our upgrade so this PR won't be able to be applied. Thanks for keeping it open for so long. |
New imas-python 2.1.0 release disabled implicit conversion between major DD versions #82 which broke imas loader test (change from warning to RuntimeError).
Updated imas-python requirement and fixed the test.