Add gemini-3.5-flash model support#121
Conversation
Update README available models and default model selection
There was a problem hiding this comment.
Code Review
This pull request updates the default model to gemini-3.5-flash and introduces a comprehensive set of new predefined computer use functions, while maintaining backward compatibility for legacy models. Feedback on these changes highlights a critical runtime TypeError in agent.py where handle_legacy_action is called without its required action argument. Additionally, improvements are suggested in playwright.py to use Playwright's native click_count parameter for triple clicks and wait_for_timeout instead of time.sleep, as well as explicitly casting the magnitude argument to an integer in agent.py to prevent type errors.
| elif action.name == "scroll": | ||
| x = self.denormalize_x(action.args["x"]) | ||
| y = self.denormalize_y(action.args["y"]) | ||
| magnitude = action.args.get("magnitude", 800) |
There was a problem hiding this comment.
It is safer to explicitly cast the magnitude argument to an integer (similar to how seconds is cast in the wait action handler) to prevent potential type errors if the argument is parsed as a string or float.
| magnitude = action.args.get("magnitude", 800) | |
| magnitude = int(action.args.get("magnitude", 800)) |
3967bdb to
49d6dc6
Compare
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
No description provided.