Skip to content

Add gemini-3.5-flash model support#121

Merged
ryanguo-google merged 7 commits into
mainfrom
new-cu-tool
Jun 24, 2026
Merged

Add gemini-3.5-flash model support#121
ryanguo-google merged 7 commits into
mainfrom
new-cu-tool

Conversation

@ryanguo-google

Copy link
Copy Markdown
Collaborator

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the default model to gemini-3.5-flash and introduces a comprehensive set of new predefined computer use functions, while maintaining backward compatibility for legacy models. Feedback on these changes highlights a critical runtime TypeError in agent.py where handle_legacy_action is called without its required action argument. Additionally, improvements are suggested in playwright.py to use Playwright's native click_count parameter for triple clicks and wait_for_timeout instead of time.sleep, as well as explicitly casting the magnitude argument to an integer in agent.py to prevent type errors.

Comment thread agent.py Outdated
Comment thread computers/playwright/playwright.py
Comment thread computers/playwright/playwright.py
Comment thread agent.py
elif action.name == "scroll":
x = self.denormalize_x(action.args["x"])
y = self.denormalize_y(action.args["y"])
magnitude = action.args.get("magnitude", 800)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

It is safer to explicitly cast the magnitude argument to an integer (similar to how seconds is cast in the wait action handler) to prevent potential type errors if the argument is parsed as a string or float.

Suggested change
magnitude = action.args.get("magnitude", 800)
magnitude = int(action.args.get("magnitude", 800))

Comment thread agent.py
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@ryanguo-google ryanguo-google requested a review from ericpts June 24, 2026 17:09
@ryanguo-google ryanguo-google merged commit c93bb2d into main Jun 24, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants