Fix : Add Privacy-tos.md to docs#20424
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello @pratim994, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical documentation gap by introducing the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds a new documentation file, Privacy-tos.md, to address a broken link for privacy and terms of service. While adding the documentation is the right approach, there are a couple of issues. The new file appears to be in the wrong directory and has a name that doesn't align with the documentation site's configuration, which will likely prevent it from fixing the issue it's intended to solve. Additionally, there's a duplicated URL for two different legal documents within the file. I've added comments with details on how to resolve these issues.
| @@ -0,0 +1,96 @@ | |||
| # Gemini CLI: License, Terms of Service, and Privacy Notices | |||
There was a problem hiding this comment.
This file appears to be in the wrong location and might have the wrong name. The docs/sidebar.json file has an entry for 'Terms and privacy' with the slug docs/resources/tos-privacy, which corresponds to a file at docs/resources/tos-privacy.md. To ensure the documentation site builds correctly and the broken link is fixed, please move this file to docs/resources/ and rename it to tos-privacy.md.
|
|
||
| | Authentication Method | Service(s) | Terms of Service | Privacy Notice | | ||
| | :----------------------- | :--------------------------- | :------------------------------------------------------------------------------------------------------ | :-------------------------------------------------------------------------------------------- | | ||
| | Google Account | Gemini Code Assist services | [Terms of Service](https://developers.google.com/gemini-code-assist/resources/privacy-notices) | [Privacy Notices](https://developers.google.com/gemini-code-assist/resources/privacy-notices) | |
|
Can you update the link to point to https://github.com/google-gemini/gemini-cli/blob/main/docs/resources/tos-privacy.md instead? We recently changed the directory |
Summary
Adding Privacy-tos.md to docs , which was missing during authentication.
Details
During gemini-cli authentication there was a URL to privacy terms of service , which when clicked gave empty response .
While looking through docs , I found out that it lacked said md file, in this PR I am adding that file.
Related Issues
Related to #20400
How to Validate
Pre-Merge Checklist