fix(github): resolve actionlint and yamllint regressions from #19443#20467
Merged
fix(github): resolve actionlint and yamllint regressions from #19443#20467
Conversation
Contributor
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
|
Size Change: -2 B (0%) Total Size: 25.7 MB ℹ️ View Unchanged
|
galz10
approved these changes
Feb 26, 2026
gemini-cli
bot
added
the
area/platform
Quote GITHUB variables in several actions and workflows to resolve shellcheck SC2086 and yamllint 'quoted-strings' warnings. This ensures consistent handling of variables that may contain spaces or special characters and satisfies linting requirements. Fixes: #20466
jerop
force-pushed
the
fix/actionlint-eval-workflow
branch
from
77b5a59 to
374fe38
Compare
jerop
changed the title
|
Secure it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes several linting regressions introduced in #19443 (which was force-merged). These issues include brittle shell scripting in workflows and inconsistent YAML formatting in actions.
Problem
The force-merge of #19443 bypassed CI checks, resulting in:
quoted-stringsviolations: Missing quotes for GitHub Actions expressions withinenvblocks, violating the repository's linting standards.Changes
.github/workflows/eval.ymlby quoting"${GITHUB_REF_NAME}".quoted-stringswarnings in 12 files by applying single quotes to GHA expressions (e.g.,VALUE: '${{ inputs.param }}').Verification
Validated the fixes locally using the project's linting script:
node scripts/lint.js --actionlint(Passes)node scripts/lint.js --yamllint(Passes)Fixes #20466