update the max amount of times the Antigravity transition banner can be displayed.#27676
Conversation
|
📊 PR Size: size/S
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request modifies the CLI banner display logic to ensure critical transition messages remain visible to users. By checking for the Antigravity keyword, the system now bypasses the standard display limit, ensuring important deprecation and reroute notifications are not suppressed for users who have already seen the banner multiple times. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the useBanner hook to ensure that any banner containing an 'Antigravity' announcement is not hidden, even if its display count exceeds the maximum limit. A corresponding unit test has been added to verify this behavior. There are no review comments, and I have no feedback to provide.
|
Size Change: +36 B (0%) Total Size: 33.9 MB
ℹ️ View Unchanged
|
gemini-cli
Bot
added
the
status/need-issue
|
/patch |
|
🚀 [Step 1/4] Patch workflow(s) waiting for approval! 📋 Details:
⏳ Status: The patch creation workflow has been triggered and is waiting for deployment approval. Please visit the specific workflow links below and approve the runs. 🔗 Track Progress: |
|
🚀 [Step 2/4] Patch PR Created! 📋 Patch Details:
📝 Next Steps:
🔗 Track Progress: |
|
🚀 [Step 2/4] Patch PR Created! 📋 Patch Details:
📝 Next Steps:
🔗 Track Progress: |
|
🚀 [Step 3/4] Patch Release Waiting for Approval! 📋 Release Details:
⏳ Status: The patch release has been triggered and is waiting for deployment approval. Please visit the specific workflow run link below and approve the deployment. You'll receive another update when it completes. 🔗 Track Progress: |
|
🚀 [Step 3/4] Patch Release Waiting for Approval! 📋 Release Details:
⏳ Status: The patch release has been triggered and is waiting for deployment approval. Please visit the specific workflow run link below and approve the deployment. You'll receive another update when it completes. 🔗 Track Progress: |
|
✅ [Step 4/4] Patch Release Complete! 📦 Release Details:
🎉 Status: Your patch has been successfully released and published to npm! 📝 What's Available:
🔗 Links: |
|
✅ [Step 4/4] Patch Release Complete! 📦 Release Details:
🎉 Status: Your patch has been successfully released and published to npm! 📝 What's Available:
🔗 Links: |
4 participants
Summary
Allows CLI transition banner to be visible consistently for users that would see it rather than hiding it after 5 times.
Details
Added a workaround for the maximum amount of times a banner can be displayed so that deprecation and reroute messages are not hidden from the user even after DEFAULT_MAX_BANNER_SHOWN_COUNT times.
This is a minor workaround focused on identifying a keyword that is in expected banner messages.
How to Validate
Log in with a free tier account 5 or more times and verify that the "│ Gemini CLI is transitioning to the new Antigravity CLI for Google One and unpaid tier (Gemini Code Assist for individuals) users. " message appears consistently.
Pre-Merge Checklist