chore(caretaker): update vitest to v3.2.4 and add package-lock.json files#28409
chore(caretaker): update vitest to v3.2.4 and add package-lock.json files#28409chadd28 wants to merge 1 commit into
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request improves the build reliability and dependency consistency for the caretaker-agent services. By introducing lockfiles, it enables the use of npm ci for more stable container image builds, while the vitest upgrade ensures parity with the broader repository tooling. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
📊 PR Size: size/XL
|
There was a problem hiding this comment.
Code Review
This pull request updates the vitest dependency from version ^1.6.0 to ^3.2.4 in both the egress-service and ingestion-service packages of the caretaker-agent. There are no review comments, and I have no feedback to provide.
Note: Security Review has been skipped due to the limited scope of the PR.
Summary
Adds missing
package-lock.jsonlockfiles toingestion-serviceandegress-serviceundertools/caretaker-agent/cloudrun/, and updatesvitestto^3.2.4to align with the repository standard.Details
RUN npm ciduring Cloud Run container image builds.npm ciis faster, cleaner, and strictly deterministic for container builds, but requires apackage-lock.jsonfile.vitestfrom^1.6.0to^3.2.4in both servicepackage.jsonfiles to match the workspace version used acrossgemini-cli, resolving audit security warnings in dev dependencies.How to Validate
ingestion-serviceandegress-service:Pre-Merge Checklist