Skip to content

chore(caretaker): update vitest to v3.2.4 and add package-lock.json files#28409

Open
chadd28 wants to merge 1 commit into
google-gemini:mainfrom
chadd28:chore/caretaker-lockfiles
Open

chore(caretaker): update vitest to v3.2.4 and add package-lock.json files#28409
chadd28 wants to merge 1 commit into
google-gemini:mainfrom
chadd28:chore/caretaker-lockfiles

Conversation

@chadd28

@chadd28 chadd28 commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds missing package-lock.json lockfiles to ingestion-service and egress-service under tools/caretaker-agent/cloudrun/, and updates vitest to ^3.2.4 to align with the repository standard.

Details

  • Docker Build Requirement: The Dockerfiles for both services use RUN npm ci during Cloud Run container image builds. npm ci is faster, cleaner, and strictly deterministic for container builds, but requires a package-lock.json file.
  • Dependency Alignment: Upgraded vitest from ^1.6.0 to ^3.2.4 in both service package.json files to match the workspace version used across gemini-cli, resolving audit security warnings in dev dependencies.

How to Validate

  1. Run unit tests in ingestion-service and egress-service:
cd tools/caretaker-agent/cloudrun/ingestion-service && npm test 
cd tools/caretaker-agent/cloudrun/egress-service && npm test 

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed)
  • Added/updated tests (if needed)
  • Noted breaking changes (if any)
  • Validated on required platforms/methods:
    • MacOS
      • npm run
      • npx
      • Docker
      • Podman
      • Seatbelt
    • Windows
      • npm run
      • npx
      • Docker
    • Linux
      • npm run
      • npx
      • Docker

@chadd28
chadd28 requested a review from a team as a code owner July 15, 2026 18:00
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves the build reliability and dependency consistency for the caretaker-agent services. By introducing lockfiles, it enables the use of npm ci for more stable container image builds, while the vitest upgrade ensures parity with the broader repository tooling.

Highlights

  • Dependency Update: Upgraded vitest from ^1.6.0 to ^3.2.4 in both ingestion-service and egress-service to align with repository standards.
  • Build Optimization: Added missing package-lock.json files to support deterministic npm ci builds in Cloud Run environments.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions github-actions Bot added the size/xl An extra large PR label Jul 15, 2026
@github-actions

Copy link
Copy Markdown

📊 PR Size: size/XL

  • Lines changed: 6842
  • Additions: +6840
  • Deletions: -2
  • Files changed: 4

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the vitest dependency from version ^1.6.0 to ^3.2.4 in both the egress-service and ingestion-service packages of the caretaker-agent. There are no review comments, and I have no feedback to provide.

Note: Security Review has been skipped due to the limited scope of the PR.

@gemini-cli gemini-cli Bot added the status/need-issue Pull requests that need to have an associated issue. label Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xl An extra large PR status/need-issue Pull requests that need to have an associated issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant