Update implementation of function for pulling files from devices to create a new temporary directory for saving the file every time the function was called. #352
Merged
copybara-service[bot] merged 1 commit intomainfrom Nov 24, 2025
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
bot
force-pushed
the
test_834736315
branch
from
9a8c3b6 to
1774f06
Compare
…reate a new temporary directory for saving the file every time the function was called. This ensures the function is thread safe. The old implementation would create a single temporary directory at the module level. When running Android World from multiple threads, this could result in multiple instances trying to save files with the same name in the same directory, resulting in corrupt data. The new implementation avoids this problem. PiperOrigin-RevId: 836225493
copybara-service
bot
force-pushed
the
test_834736315
branch
from
1774f06 to
c71a6b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update implementation of function for pulling files from devices to create a new temporary directory for saving the file every time the function was called.
This ensures the function is thread safe. The old implementation would create a single temporary directory at the module level. When running Android World from multiple threads, this could result in multiple instances trying to save files with the same name in the same directory, resulting in corrupt data. The new implementation avoids this problem.