Skip to content

Replace ASSERTs with EXPECTs in accumulator test. #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Mar 26, 2026
Merged

Replace ASSERTs with EXPECTs in accumulator test. #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions openfst/test/accumulator_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,21 +45,24 @@ template <class A, class A1, class A2>
void TestAccumulator(const Fst<A>& fst, A1* accum1, A2* accum2) {
using W = typename A::Weight;
for (StateIterator<Fst<A>> siter(fst); !siter.Done(); siter.Next()) {
StateId s = siter.Value();
const StateId s = siter.Value();
accum1->SetState(s);
accum2->SetState(s);
ArcIterator<Fst<A>> aiter(fst, s);
size_t narcs = fst.NumArcs(s);
size_t mid = narcs / 2;
const size_t narcs = fst.NumArcs(s);
const size_t mid = narcs / 2;
W w1 = accum1->Sum(W::Zero(), &aiter, 0, mid);
W w2 = accum2->Sum(W::Zero(), &aiter, 0, mid);
ASSERT_TRUE(ApproxEqual(w1, w2)) << w1.Value() << " " << w2.Value();
EXPECT_TRUE(ApproxEqual(w1, w2))
<< s << ": " << w1.Value() << " " << w2.Value();
w1 = accum1->Sum(W::Zero(), &aiter, mid, narcs);
w2 = accum2->Sum(W::Zero(), &aiter, mid, narcs);
ASSERT_TRUE(ApproxEqual(w1, w2)) << w1.Value() << " " << w2.Value();
EXPECT_TRUE(ApproxEqual(w1, w2))
<< s << ": " << w1.Value() << " " << w2.Value();
w1 = accum1->Sum(W::Zero(), &aiter, 0, narcs);
w2 = accum2->Sum(W::Zero(), &aiter, 0, narcs);
ASSERT_TRUE(ApproxEqual(w1, w2)) << w1.Value() << " " << w2.Value();
EXPECT_TRUE(ApproxEqual(w1, w2))
<< s << ": " << w1.Value() << " " << w2.Value();
}
}

Expand All @@ -71,7 +74,7 @@ class AccumulatorTest : public testing::Test {
"openfst/test/testdata/accumulator/ac.fst")));
}

std::unique_ptr<VectorFst<Arc>> fst_;
std::unique_ptr<const VectorFst<Arc>> fst_;
};

TEST_F(AccumulatorTest, LogAccumulatorTest) {
Expand Down
Loading