Skip to content

Wait for tool confirmation before sending responses#883

Open
Haihan-Jiang wants to merge 1 commit into
google:mainfrom
Haihan-Jiang:codex/adk-go-confirmation-wait
Open

Wait for tool confirmation before sending responses#883
Haihan-Jiang wants to merge 1 commit into
google:mainfrom
Haihan-Jiang:codex/adk-go-confirmation-wait

Conversation

@Haihan-Jiang
Copy link
Copy Markdown

Summary

  • stop emitting placeholder function responses for tool calls that are waiting on HITL confirmation
  • keep the adk_request_confirmation event as the pending client signal
  • update functiontool, MCP toolset, parallel HITL, and A2A expectations

Fixes #876

Testing

  • go test ./internal/llminternal ./tool/functiontool ./tool/mcptoolset
  • go test ./agent/remoteagent/v2 ./internal/llminternal ./tool/functiontool ./tool/mcptoolset
  • go test ./runner ./agent/... ./internal/llminternal ./tool/...
  • git diff --check

Note: go test ./... exposed an unrelated transient ordering failure in server/adkrest/internal/services TestDebugTelemetryGetSpansBySessionID; rerunning that package-specific test passed.

@Haihan-Jiang Haihan-Jiang marked this pull request as ready for review May 24, 2026 20:52
@Haihan-Jiang
Copy link
Copy Markdown
Author

This is ready for review. The flow now waits for tool confirmation before sending function responses, with parallel/HITL coverage added. The visible checks are green.

@indurireddy-TF
Copy link
Copy Markdown
Contributor

Hi @Haihan-Jiang Thanks for putting this PR together to resolve the confirmation bug. Some merge conflicts have appeared on your branch. Could you please resolve them so we can proceed with the review?

@Haihan-Jiang Haihan-Jiang force-pushed the codex/adk-go-confirmation-wait branch from dd7572e to feb05d9 Compare June 7, 2026 23:22
@Haihan-Jiang
Copy link
Copy Markdown
Author

Thanks for the heads up. I rebased the branch on the latest main and resolved the conflicts.

I also re-ran the affected packages locally:

  • go test ./agent/remoteagent/v2 ./internal/llminternal ./tool/functiontool ./tool/mcptoolset

The updated head is feb05d9, and GitHub shows the commit signature as valid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The tool execution starts before the user confirmation is received

2 participants