fix(skilltoolset): document load_skill param as name, not skill_name#919
Open
koriyoshi2041 wants to merge 1 commit into
Open
fix(skilltoolset): document load_skill param as name, not skill_name#919koriyoshi2041 wants to merge 1 commit into
koriyoshi2041 wants to merge 1 commit into
Conversation
Contributor
|
Thank you for opening this PR. This correctly resolves the schema mismatch in skilltoolset where the default system instruction incorrectly directed models to use skill_name instead of name for load_skill I have verified the test cases, and they are working as expected. @kdroste-google @foxfrikses @baptmont , could you please take a look at these changes and review the PR when you have a moment? |
The default system instruction told the model to call the load_skill tool with skill_name="<SKILL_NAME>", but LoadSkillArgs marshals its field as "name". The first load_skill call in each session was therefore rejected for an unknown field and only recovered via retry. Use name= to match the schema.
2326ad5 to
a6ee693
Compare
Author
|
Rebased this onto current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #912.
The default
SkillToolsetsystem instruction tells the model:but the
load_skilltool input (skilltool.LoadSkillArgs) marshals its field asname:So the first
load_skillcall in a session is rejected for an unknownskill_namefield and only succeeds after the model retries withname. Updated the instruction to documentname="<SKILL_NAME>"to match the schema. (load_skill_resourcekeeps its ownskill_nameparameter — that one is unchanged.)Added
TestDefaultInstructionMatchesLoadSkillSchema, which reflects the JSON tag offLoadSkillArgs.Nameand asserts the default instruction documents that exact parameter forload_skill(and no longerskill_name=), so the two cannot drift apart again.go test ./tool/skilltoolset/...passes.