Adding VertexAI SkillsRegistry SkillsToolset Source#928
Open
nicholasbreckwoldt wants to merge 5 commits into
Open
Adding VertexAI SkillsRegistry SkillsToolset Source#928nicholasbreckwoldt wants to merge 5 commits into
nicholasbreckwoldt wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Issue or Description of Change
Describe the change:
Adding support for VertexAI SkillsRegistry.
Solution:
Integrating support for
VertexAI SkillsRegistrythrough introducing a new Skills Source within current SkillsToolset implementation.Also proposes an extended
Sourceinterface to support dynamic retrieval of skills through Search, complimented by adding a newSearchSkillsto the SkillsToolset.Testing Plan
Testing with SkillsRegistry within own Google Cloud project.
Unit Tests:
Please include a summary of passed go test results.
go test ./tool/skilltoolset/... ok google.golang.org/adk/tool/skilltoolset ok google.golang.org/adk/tool/skilltoolset/internal/skilltool ok google.golang.org/adk/tool/skilltoolset/skill ok google.golang.org/adk/tool/skilltoolset/skill/vertexai 2.965sManual End-to-End (E2E) Tests:
Manually testing using Google Cloud project SkillsRegistry configuration (and pre-bundled gcp-skill-registry skil).
Code snippet below:
ADK WebUI interaction example 1:
ADK WebUI interaction example 2:
Checklist
Additional context
Due to current lacking formal support of SkillsRegistry in Golang Google Cloud library, the current proposed VertexAI SkillsRegistry client implementation relies on REST invocation. The elegance of this can certainly be improved by replacing wtih gRPC clients and protobuf definitions once made publically available.