Skip to content

fix(skilltoolset): use name arg in load_skill instruction#976

Open
Zhang-986 wants to merge 1 commit into
google:mainfrom
Zhang-986:codex/fix-skilltoolset-load-skill-instruction
Open

fix(skilltoolset): use name arg in load_skill instruction#976
Zhang-986 wants to merge 1 commit into
google:mainfrom
Zhang-986:codex/fix-skilltoolset-load-skill-instruction

Conversation

@Zhang-986
Copy link
Copy Markdown

Summary

  • correct the default SkillToolset instruction to call load_skill with name="<SKILL_NAME>", matching LoadSkillArgs
  • add regression assertions so ProcessRequest no longer reintroduces the stale skill_name argument for load_skill

Fixes #912.

Testing

  • go test ./tool/skilltoolset/...
  • go test ./... was also run; it currently fails in google.golang.org/adk/server/adkrest/internal/services on TestDebugTelemetryGetSpansBySessionID due span ordering mismatches unrelated to this tool/skilltoolset change. Re-running that package with -count=3 reproduces the same ordering failure.

@google-cla
Copy link
Copy Markdown

google-cla Bot commented Jun 7, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Zhang-986 Zhang-986 force-pushed the codex/fix-skilltoolset-load-skill-instruction branch from 59ec7c9 to b8eb340 Compare June 7, 2026 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SkillToolset default SystemInstruction documents skill_name= for load_skill, but the schema expects name=

1 participant